Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the dependency between TestTools and TestHelpers #401

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Get rid of the dependency between TestTools and TestHelpers #401

merged 1 commit into from
Dec 4, 2023

Conversation

testableapple
Copy link
Contributor

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/644

🎯 Goal

  • To improve developer experience, move required stuff from TestHelpers to TestTools

📝 Summary

  • Just moved stuff required by Unit tests from TestHelpers to TestTools

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added 🔧 WIP A PR that is Work In Progress 🤖 CI/CD Any work related to CI/CD labels Nov 17, 2023
@testableapple testableapple force-pushed the ci/test-tools-dependencies branch 2 times, most recently from be3992d to 5c373d9 Compare November 23, 2023 13:27
@testableapple testableapple force-pushed the ci/test-tools-dependencies branch from 5c373d9 to 27d1475 Compare December 4, 2023 12:24
@testableapple testableapple removed the 🔧 WIP A PR that is Work In Progress label Dec 4, 2023
@testableapple testableapple force-pushed the ci/test-tools-dependencies branch from 27d1475 to 8d86b4b Compare December 4, 2023 12:46
@testableapple testableapple marked this pull request as ready for review December 4, 2023 12:46
@testableapple testableapple requested a review from a team as a code owner December 4, 2023 12:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

70.3% 70.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@testableapple testableapple merged commit 2f3fa25 into main Dec 4, 2023
8 of 10 checks passed
@testableapple testableapple deleted the ci/test-tools-dependencies branch December 4, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testableapple @martinmitrevski